#6 closed defect (fixed)
Function bool HD_PS_Base::WriteOut() does not return anything
| Reported by: | Aleksey.Khudyakov@cern.ch | Owned by: | Frank Siegert |
|---|---|---|---|
| Priority: | trivial | Milestone: | |
| Component: | Unknown | Version: | 1.0.11 |
| Keywords: | Cc: |
Description
in file /HADRONS++-0.0.11/PS_Library/HD_PS_Base.C function HD_PS_Base::WriteOut() doesn't return value but have bool return value. Obvious bug.
P.S. Compiling with -Wall good idea too...
Attachments (0)
Change History (5)
comment:1 Changed 16 years ago by
comment:2 Changed 16 years ago by
| Owner: | changed from support@sherpa-mc.de to Frank Siegert |
|---|---|
| Status: | new → assigned |
Hi Aleksey,
thank you for your bug report.
Replying to Aleksey.Khudyakov@cern.ch:
in file /HADRONS++-0.0.11/PS_Library/HD_PS_Base.C function HD_PS_Base::WriteOut() doesn't return value but have bool return value. Obvious bug.
I would not go as far as calling this a bug (and you also classified it as 'trivial'), because it does not introduce any buggy behaviour. Nonetheless, we will strive to eliminate such trivial compiler warnings in the next release. We won't provide a patch for released versions though, because the problem reported does not cause _any_ problem in the usage of Sherpa.
Thanks again, Frank
comment:3 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed in recent versions.
comment:4 Changed 12 years ago by
| Milestone: | → rel-old |
|---|
I've looked trough compiler warning. And here is list of function which does not (or sometime does not) return value.
Cluster_Part.C: In member function `bool AHADIC::Cluster_Part::UpdateDecay(AHADIC::Cluster*, int)': Cluster_Part.C:226: warning: control reaches end of non-void function
Tau_Decay_MEs.C:331: warning: control reaches end of non-void function Tau_Decay_MEs.C: In member function `virtual Complex
HADRONS::Tau_Four_Pion_3::KS::operator()(int)': Tau_Decay_MEs.C:1646: warning: control reaches end of non-void function
Tau_Decay_MEs.H: In member function `virtual Complex HADRONS::Tau_Four_Pion_3::LorenzBase::operator()(int)':
Tau_Decay_MEs.H:317: warning: control reaches end of non-void function Tau_Decay_MEs.H: In member function `virtual Complex
HADRONS::Tau_Four_Pion_1::LorenzBase::operator()()': Tau_Decay_MEs.H:400: warning: control reaches end of non-void function
Herwig_HepEvt_Translator.C: In member function `bool SHERPA::Herwig_HepEvt_Translator::ConstructBlobs(ATOOLS::Blob_List*)': Herwig_HepEvt_Translator.C:852: warning: control reaches end of non-void function
And a lot of unused variables too.