sherpa is hosted by Hepforge, IPPP Durham
close Warning: Can't synchronize with repository "(default)" (/hepforge/svn/sherpa does not appear to be a Subversion repository.). Look in the Trac log for more information.
Modify ↓

Opened 7 years ago

Last modified 7 years ago

#376 new defect

'%'-style commenting not working throughout the run card

Reported by: silvan Owned by: Frank Siegert
Priority: major Milestone: rel-2.3.0
Component: Hadron Decays Version: 2.2.3
Keywords: Cc:

Description

The '%' seems not to work everywhere in the run card. It can be reproduced by trying to comment out the specification of BEAM parameters in any run card.

Attachments (0)

Change History (2)

comment:1 Changed 7 years ago by silvan

Summary: '%'-style commenting not working throughout the run car → '%'-style commenting not working throughout the run card

comment:2 Changed 7 years ago by Enrico Bothmann

Hi Silvan,

I'm not sure in how far I'd consider this a bug. The default is definitely '#' (e.g. set as the default in Read_Write_Base), all other options scattered throughout the code are only there for confusion.

In trunk, the Default_Reader is introduced such that the behaviour can be configured in one place for all options. It uses '#' and '!' as comment characters.

On 2.2.3, a Data_Reader instance is used and set up with '#' and '!' in Initialization_Handler::InitializeTheModel for reading the BEAM parameters. You could add AddComment('%') there. But again, I'm not sure why we should support more than one comment character, and '#' is definitely the most widely used. Also, in a few months, we will transition to YAML anyway (work in progress in yamlread2 branch) ...

So I think if there is a broken Example, we should migrate it to use '#', and otherwise leave everything as is for now.

Modify Ticket

Change Properties
Action
as new The owner will remain Frank Siegert.
as The resolution will be set.
to The owner will be changed from Frank Siegert to the selected user.
The owner will be changed from Frank Siegert to anonymous.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.